Questions about Code Reviews
- by bamboocha
My team plans to do Code Review and asked me to make a concept what and how we are going to make our Code Reviews. We are a little group of 6 team members.
We use an SVN repository and write programs in different languages (mostly: VB.NET, Java, C#), but the reviews should be also possible for others, yet not defined. Basically I am asking you, how are you doing it, to be more precise I made a list of some questions I got:
1. Peer Meetings vs Ticket System?
Would you tend to do meetings with all members, rather than something like a ticket system, where the developer can add a new code change and some or all need to check and approve it?
1. What tool?
I made some researches on my own and it showed that Rietveld seems to be the program to use for non-git solutions. Do you agree/disagree and why?
2. A good workflow to follow?
3. Are there good ways to minimize the effort for those meetings even more?
4. What are good questions, every code reviewer should follow?
I already made a list with some questions, what would you append/remove?
are there any magic numbers in the code?
do all variable and method names make sense and are easily understandable?
are all querys using prepared statement?
are all objects disposed/closed when they are not needed anymore?
5. What are your general experiences with it?
What's important?
Things to consider/prevent/watch out?
